Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] SEGFAULT in js_Subscribe if consumer Name is NULL #696

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FIXED] SEGFAULT in js_Subscribe if consumer Name is NULL #696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2afa4
[FIXED] SEGFAULT in js_Subscribe if consumer Name is NULL
levb Nov 16, 2023
f8d500c
Merge branch 'main' into lev-GH-695-SEGFAULT
levb Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/js.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2656,7 +2656,10 @@ _subscribe(natsSubscription **new_sub, jsCtx *js, const char *subject, const cha
// set only if jsi->consumer is NULL!
if (jsi->consumer == NULL)
{
DUP_STRING(s, jsi->consumer, info->Name);
if (info->Name != NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why name would be NULL? It should be set no? I am not sure if just doing that here does not move the problem to some other place.

{
DUP_STRING(s, jsi->consumer, info->Name);
}
if (s == NATS_OK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I wonder if I should not have done the rest of that code for pull consumers only...

{
NATS_FREE(jsi->nxtMsgSubj);
Expand Down