Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] build error (#819) #820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIXED] build error (#819) #820

wants to merge 1 commit into from

Conversation

oldnick85
Copy link

add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

[FIXED] build error (nats-io#819)
794a263 
add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF
kozlovic
kozlovic approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/glib/glib.c
@@ -11,6 +11,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <stddef.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got lost during PR #778. The change here looks good to me.

Since we need this header (so far) only because of "offsetof" that is only in this C file, it could simply be included here, but I will let @levb decide if he would rather have it in "glibp.h".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oldnick85 @kozlovic