Explicitly created threads now set IsBackground=true to avoid prevent…

…ing a process using this library from terminating. (#354)
nats-io · Jan 13, 2020 · b4c7ca3 · b4c7ca3
1 parent 2687668
commit b4c7ca3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/NATS.Client/Conn.cs b/src/NATS.Client/Conn.cs
@@ -989,6 +989,7 @@ private void spinUpSocketWatchers()
                 readLoopStartEvent.Set();
                 readLoop();
             });
+            t.IsBackground = true;
             t.Start();
             t.Name = generateThreadName("Reader");
             wg.Add(t);
@@ -998,6 +999,7 @@ private void spinUpSocketWatchers()
                 flusherStartEvent.Set();
                 flusher();
             });
+            t.IsBackground = true;
             t.Start();
             t.Name = generateThreadName("Flusher");
             wg.Add(t);
@@ -1481,6 +1483,7 @@ private void processReconnect()
                 {
                     doReconnect();
                 });
+                t.IsBackground = true;
                 t.Name = generateThreadName("Reconnect");
                 t.Start();
             }

diff --git a/src/Samples/Benchmark/Benchmark.cs b/src/Samples/Benchmark/Benchmark.cs
@@ -369,6 +369,7 @@ void runReqReply(string testName, long testCount, long testSize)
                     subConn.Flush();
                 }
             });
+            t.IsBackground = true;
             t.Start();
 
             Thread.Sleep(1000);
@@ -413,6 +414,7 @@ async Task runReqReplyAsync(string testName, long testCount, long testSize)
                     subConn.Flush();
             }
             });
+            t.IsBackground = true;
             t.Start();
 
             Thread.Sleep(1000);