Trekker ut api-modell i egen branch. #1039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routsi
reviewed
Nov 12, 2024
| @@ -9,7 +9,7 @@ plugins { | |||
| } | |||
|
|
|||
| group = "no.nav.pensjon.brev" | |||
| version = "99" | |||
| version = "100" | |||
There was a problem hiding this comment.
101 er siste utgitte versjon
routsi
reviewed
Nov 12, 2024
| val pe_ut_virkningfomar: Int, | ||
| val pe_sivilstand_ektefelle_partner_samboer_bormed_ut_en: String, |
There was a problem hiding this comment.
Regner med at det er sortering som slår inn her?
Vær obs på at om det ikke brukes named arguments så vil dette fort skape problemer
routsi
reviewed
Nov 12, 2024
| @@ -2,5 +2,6 @@ package no.nav.pensjon.brev.api.model.maler.legacy.grunnlag | |||
|
|
|||
|
|
|||
| data class Grunnlag( | |||
| val persongrunnlagsliste: List<Persongrunnlag> | |||
There was a problem hiding this comment.
Kan vi ikke ha emptyList istedenfor null?
routsi
reviewed
Nov 12, 2024
| @@ -6,4 +6,5 @@ data class BeregningsgrunnlagOrdinar( | |||
| val antallarover1g: Int?, | |||
| val antallarinntektiavtaleland: Int?, | |||
| val beregningsgrunnlagordinerarsbelop: Kroner?, | |||
| val opptjeningutliste: List<OpptjeningUT>?, | |||
routsi
reviewed
Nov 12, 2024
|
|
||
| data class BeregningsgrunnlagAvdodOrdiner( | ||
| val arsbelop: Kroner?, | ||
| val opptjeningutliste: List<OpptjeningUT>?, |
routsi
reviewed
Nov 12, 2024
| val onsketvirkningsdato: LocalDate?, | ||
| ) |
There was a problem hiding this comment.
en tab for mye på parantes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tilhørende endringer ligger i en annen branch