Førebu bibliotek, del 1: Kutte koplingar til spesifikke malar frå brevbaker #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsop-nav
requested review from
hanneanes,
paomoo and
a team
as code owners
madsop-nav
changed the title
…å i neste runde flytte ProductionTemplates ut frå repoet
…tlegvis kunne overstyre i testar
…så for integrasjonstestane
… eiga fil, så resten av modul-initen kan vera uavhengig av lista over malar
madsop-nav
force-pushed
the
foerebu-bibliotek
branch
from
0d89e96
to
8fd25ac
Compare
routsi
reviewed
Nov 28, 2024
|
|
||
| configureMetrics() | ||
| brevbakerRouting(jwtConfigs.map { it.name }.toTypedArray(), latexCompilerService, templates) | ||
| monitor.subscribe(ServerReady) { it.log.info("Ferdig med å sette opp applikasjonen") } |
There was a problem hiding this comment.
Kan kanskje flytte denne subscriben opp til den andre i toppen av modulen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legg til rette for å kunne gjera brevbaker til bibliotek ved å gå bort frå å bruke spesifikke pensjonsmalar i testar etc, og å starte å innføre abstraksjonslag og saumar for å kople inn dei spesifikke breva.
Forholdsvis ufarleg og enkel PR, som legg til rette for å gjera større endringar etterpå. Steg for steg.