Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD] Improve drainage class parsing #75

Merged
merged 16 commits into from
Feb 24, 2024
Merged

[OSD] Improve drainage class parsing #75

merged 16 commits into from
Feb 24, 2024

Conversation

brownag
Copy link
Member

@brownag brownag commented Feb 23, 2024

Incremental fixes:

  • Generalize drainage class pattern: current "first" matching misses a lot of cases with the word "drained" twice (n=604 series affected; previously single class became multi class)
  • Order (excessively -> very poorly) and interpolate between series ranges that span two or more classes (n=1306 series)
  • Fix parsing of subaqueous drainage class (n=69 series)
  • Fix parsing of hyphenated drainage class (n=792 series)
  • Fix list-style Drainage and Permeability sections (i.e. "Drainage: well" or Drainage class: somewhat poorly) (n=269 series)

brownag and others added 2 commits February 22, 2024 23:04
 - current "first" matching misses a lot of cases with the word "drained" twice
@brownag brownag linked an issue Feb 23, 2024 that may be closed by this pull request
7 tasks
@brownag brownag added enhancement New feature or request OSD Official Series Descriptions labels Feb 23, 2024
@brownag brownag merged commit 0b86519 into main Feb 24, 2024
@brownag brownag deleted the osd-drainage branch February 24, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OSD Official Series Descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OSD] Standard phrasing and order for drainage class in JSON output
1 participant