Remove aliases for NASIS columns, replace with physical column name #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #242. Nearly time to rip off the band-aid. For now just a draft PR to facilitate testing.
This is a breaking change for many things that rely on soilDB to query NASIS. It can be difficult to explain to new soilDB users why some columns are aliased and others follow the data model. It will be good to rely on the defined physical column names and standard associated metadata for better parity with internal NASIS queries, web reports, and the official data model in general.
Removes the following aliases in use in
fetchNASIS()
- andfetchVegdata()
-related functions.Replacing with NASIS physical column name as follows:
Aliases are still used for the foreign key columns that end in "ref" as many soilDB queries target multiple related tables, so it doesn't always make sense to include "ref" and users benefit from the shorter name e.g.
peiid
rather thanpeiidref