Fix problems pointed out by the govet linter

ncw · Oct 7, 2021 · 626d24f · 626d24f
1 parent 110725a
commit 626d24f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/swift.go b/swift.go
@@ -424,7 +424,6 @@ func (c *Connection) doTimeoutRequest(timer *time.Timer, req *http.Request) (*ht
 		cancelRequest(c.Transport, req)
 		return nil, TimeoutError
 	}
-	panic("unreachable") // For Go 1.0
 }
 
 // Set defaults for any unset values

diff --git a/swift_test.go b/swift_test.go
@@ -491,10 +491,10 @@ func TestAuthenticateRace(t *testing.T) {
 			defer wg.Done()
 			err := c.Authenticate(ctx)
 			if err != nil {
-				t.Fatal("Auth failed", err)
+				t.Error("Auth failed", err)
 			}
 			if !c.Authenticated() {
-				t.Fatal("Not authenticated")
+				t.Error("Not authenticated")
 			}
 		}()
 	}

diff --git a/swifttest/server.go b/swifttest/server.go
@@ -1023,7 +1023,6 @@ func (s *SwiftServer) serveHTTP(w http.ResponseWriter, req *http.Request) {
 		if !ok {
 			s.RUnlock()
 			panic(notAuthorized())
-			return
 		}
 
 		a.user = s.Accounts[session.username]

diff --git a/timeout_reader.go b/timeout_reader.go
@@ -47,7 +47,6 @@ func (t *timeoutReader) Read(p []byte) (int, error) {
 		t.cancel()
 		return 0, TimeoutError
 	}
-	panic("unreachable") // for Go 1.0
 }
 
 // Close the channel