Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show quickfix after compile & Introduce manual code cleanup action #284

Closed
wants to merge 4 commits into from

Conversation

asmodeus812
Copy link

@asmodeus812 asmodeus812 commented May 1, 2024

Make compile and build more robust, make error reporting more verbose, show quickfix list with the error entries. Add a newly introduced jdtls clean up action that applies manual cleanup.

if (res == CompileWorkspaceStatus.withError) {
showCompileBuildDiagnostics()
window.showWarningMessage("Compilation finished with errors")
}
setTimeout(() => { // set a timeout so user would still see the message when build time is short
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug with this reject, the progress for compile was stuck on Compiling... passed result to resolve

@asmodeus812
Copy link
Author

asmodeus812 commented May 1, 2024

Resolves #283 and #279

@asmodeus812
Copy link
Author

@chemzqm could you take a look, thanks

@asmodeus812 asmodeus812 changed the title Show quickfix after compile or build encounters errors. Show quickfix after compile & Introduce manual code cleanup action May 2, 2024
@asmodeus812 asmodeus812 closed this May 2, 2024
@sainnhe
Copy link

sainnhe commented May 27, 2024

So sad that this PR gets closed. Is there any chance to reopen this PR and let it merged?

@asmodeus812
Copy link
Author

asmodeus812 commented May 27, 2024

@sainnhe my guy, if you take a look at my fork, it is already ahead by two commits - https://github.com/asmodeus812/coc-java. Those include the changes to the action amongst other things, my extension is published under coc-java-dev in npm registry, if you wish you can use that.

I closed this pr because i rebased and removed this commit which was about to be merged in coc-java, but either way this projects seems to be stale atm, eventually if it gets revived i am happy to merge my changes in.

@sainnhe
Copy link

sainnhe commented May 27, 2024

Great work, thanks! I'm going to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants