-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show quickfix after compile & Introduce manual code cleanup action #284
Conversation
show quickfix list with the error entries
if (res == CompileWorkspaceStatus.withError) { | ||
showCompileBuildDiagnostics() | ||
window.showWarningMessage("Compilation finished with errors") | ||
} | ||
setTimeout(() => { // set a timeout so user would still see the message when build time is short |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bug with this reject, the progress for compile was stuck on Compiling... passed result to resolve
@chemzqm could you take a look, thanks |
So sad that this PR gets closed. Is there any chance to reopen this PR and let it merged? |
@sainnhe my guy, if you take a look at my fork, it is already ahead by two commits - https://github.com/asmodeus812/coc-java. Those include the changes to the action amongst other things, my extension is published under I closed this pr because i rebased and removed this commit which was about to be merged in coc-java, but either way this projects seems to be stale atm, eventually if it gets revived i am happy to merge my changes in. |
Great work, thanks! I'm going to look at it. |
Make compile and build more robust, make error reporting more verbose, show quickfix list with the error entries. Add a newly introduced jdtls clean up action that applies manual cleanup.