-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directories list #114
Open
nomasprime
wants to merge
1
commit into
neoclide:master
Choose a base branch
from
nomasprime:add-directories-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add directories list #114
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import { ChildProcess, spawn } from 'child_process' | ||
import { workspace } from 'coc.nvim' | ||
import FilesList, { Task as FilesTask } from './files' | ||
import { executable } from './util' | ||
|
||
class Task extends FilesTask { | ||
protected post_process_hook(process: ChildProcess) { | ||
let post_process = spawn('sh', ['-c', 'xargs -I {} gdirname {} | sort | uniq']) | ||
this.processes.push(post_process) | ||
post_process.on('error', e => { | ||
this.emit('error', e.message) | ||
}) | ||
process.stdout.pipe(post_process.stdin) | ||
|
||
return post_process.stdout | ||
} | ||
} | ||
|
||
export default class DirectoriesList extends FilesList { | ||
public task = Task | ||
public readonly name = 'directories' | ||
public description = 'Search directories by rg or ag' | ||
public readonly detail = `Install ripgrep in your $PATH to have best experience. | ||
Directories are searched from current cwd by default. | ||
Provide directory names as arguments to search other directories. | ||
Use 'list.source.directories.command' configuration for custom search command. | ||
Use 'list.source.directories.args' configuration for custom command arguments. | ||
Note that rg ignore hidden directories by default.` | ||
public options = [{ | ||
name: '-F, -folder', | ||
description: 'Search directories from current workspace folder instead of cwd.' | ||
}, { | ||
name: '-W, -workspace', | ||
description: 'Search directories from all workspace folders instead of cwd.' | ||
}] | ||
|
||
public getCommand(): { cmd: string, args: string[] } { | ||
let config = workspace.getConfiguration('list.source.directories') | ||
let cmd = config.get<string>('command', '') | ||
let args = config.get<string[]>('args', []) | ||
if (!cmd) { | ||
if (executable('rg')) { | ||
return { cmd: 'rg', args: this.getArgs(args, ['--color', 'never', '--files']) } | ||
} else if (executable('ag')) { | ||
return { cmd: 'ag', args: this.getArgs(args, ['-f', '-g', '.', '--nocolor']) } | ||
} else if (process.platform == 'win32') { | ||
return { cmd: 'dir', args: this.getArgs(args, ['/a-D', '/S', '/B']) } | ||
} else if (executable('find')) { | ||
return { cmd: 'find', args: this.getArgs(args, ['.', '-type', 'f']) } | ||
} else { | ||
throw new Error('Unable to find command for directories list.') | ||
return null | ||
} | ||
} else { | ||
return { cmd, args } | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use
sort --unique
instead ofsort | uniq
. But isn't there better ways than spawning another shell?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kidonng. I've noticed it's very slow on larger projects. Hopefully I'll have time to improve it soon.