Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): disable refresh when !autoRefresh OR !force #3307

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

fannheyward
Copy link
Member

autoRefresh and force are independent

close #3306

autoRefresh and force are independent

close #3306
@oblitum
Copy link
Member

oblitum commented Aug 24, 2021

Can confirm this fixes the issue.

@fannheyward
Copy link
Member Author

Tests are broken, working on this.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #3307 (96a1221) into master (8354791) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
- Coverage   74.51%   74.50%   -0.02%     
==========================================
  Files         189      189              
  Lines       19415    19416       +1     
  Branches     4336     4337       +1     
==========================================
- Hits        14468    14466       -2     
  Misses       3184     3184              
- Partials     1763     1766       +3     
Impacted Files Coverage Δ
src/diagnostic/manager.ts 84.34% <50.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8354791...96a1221. Read the comment docs.

@fannheyward
Copy link
Member Author

fannheyward commented Aug 24, 2021

  1. Check force only before refresh. The preview fix commit will break diagnosticRefresh action
  2. disable refresh if autoRefresh is disable at 1 InsertLeave, 2 onDidDiagnosticsChange 3 onDidDiagnosticsClear

@chemzqm chemzqm merged commit 73daa20 into master Aug 24, 2021
@chemzqm chemzqm deleted the fix/diag-refresh branch August 24, 2021 11:30
@oblitum
Copy link
Member

oblitum commented Aug 24, 2021

fwiw, coc-git presents similar situation neoclide/coc-git#182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diagnostic.autoRefresh = false is not effective
3 participants