Add GUC controlling whether to pause recovery if some critical GUCs at replica have smaller value than on primary #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MMeent
requested changes
Sep 19, 2024
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
0bb232c
to
b47180d
Compare
hlinnaka
reviewed
Oct 30, 2024
Comment on lines
4860
to
4866
| ereport(FATAL, | ||
| ereport(recoveryPauseOnMisconfig ? FATAL : WARNING, | ||
| (errcode(ERRCODE_INVALID_PARAMETER_VALUE), | ||
| errmsg("recovery aborted because of insufficient parameter settings"), |
There was a problem hiding this comment.
This is misleading. You print a WARNING that says "recovery aborted", but it is not aborted.
The GUC name is misleading too: if it's 'on', you abort rather than pause here.
There was a problem hiding this comment.
Yeh, I tried to minimise changed... Will replace the message.
Can you suggest some better name for the GUC? allow_replica_misconfig ?
added 2 commits
November 13, 2024 19:07
…t replica have smaller value than on primary
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
b47180d
to
e6e8408
Compare
hlinnaka
reviewed
Nov 27, 2024
| if (!recoveryPauseOnMisconfig) | ||
| if (!allowReplicaMisconfig) | ||
| { | ||
| /* Сontinue replication even though it can cause problerms later */ |
There was a problem hiding this comment.
Suggested change
| /* Сontinue replication even though it can cause problerms later */ | |
| /* Сontinue replication even though it can cause problems later */ |
| @@ -91,6 +91,7 @@ TimestampTz recoveryTargetTime; | |||
| const char *recoveryTargetName; | |||
| XLogRecPtr recoveryTargetLSN; | |||
| int recovery_min_apply_delay = 0; | |||
| bool allowReplicaMisconfig = false; | |||
There was a problem hiding this comment.
Where's the GUC for this defined? It was in guc_tables.c in an earlier version of this PR but I don't see it anymore. Is it in the neon extension perhaps? If so, let's add a comment here pointing that out.
MMeent
reviewed
Nov 27, 2024
| @@ -4809,6 +4810,12 @@ RecoveryRequiresIntParameter(const char *param_name, int currValue, int minValue | |||
| currValue, | |||
| minValue))); | |||
|
|
|||
| if (!allowReplicaMisconfig) | |||
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| if (!allowReplicaMisconfig) | |
| if (allowReplicaMisconfig) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neondatabase/neon#9023