Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some profiling improvements #31

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Some profiling improvements #31

wants to merge 2 commits into from

Conversation

fredizzimo
Copy link
Member

  • Fix the end frame, it was called twice before, and before present. Now it's after present, which matches the wgpu-profiler sample code.
  • Disable some high frequency profiling events with too much overhead

@fredizzimo
Move the profiler end frame after present
2924509 
End frame was called twice before, and now it also matches the example in wgpu-profiler.
@fredizzimo
Remove some high frequency profiling events
3e2b3b6 
The overhead is a bit too big to keep enabled all the time.
@fredizzimo fredizzimo marked this pull request as draft July 31, 2024 07:31
@fredizzimo
Copy link
Member Author

The duplicate end frame is because Neovide also does it, so this fix is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fredizzimo