-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split ckb-gen-types from ckb-types #4073
Merged
zhangsoledad
merged 24 commits into
nervosnetwork:develop
from
EthanYuan:refactor-ckb-types
Aug 17, 2023
Merged
refactor: split ckb-gen-types from ckb-types #4073
zhangsoledad
merged 24 commits into
nervosnetwork:develop
from
EthanYuan:refactor-ckb-types
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanYuan
force-pushed
the
refactor-ckb-types
branch
7 times, most recently
from
July 25, 2023 09:38
d21cafe
to
335a9c6
Compare
EthanYuan
requested review from
doitian and
zhangsoledad
and removed request for
a team
July 25, 2023 11:49
EthanYuan
force-pushed
the
refactor-ckb-types
branch
from
July 27, 2023 06:52
3fc453b
to
5be965e
Compare
chenyukang
approved these changes
Aug 3, 2023
eval-exec
reviewed
Aug 7, 2023
eval-exec
approved these changes
Aug 7, 2023
EthanYuan
force-pushed
the
refactor-ckb-types
branch
2 times, most recently
from
August 16, 2023 17:48
c149793
to
2022674
Compare
fix PHONY "gen" in Makefile.
zhangsoledad
approved these changes
Aug 17, 2023
eval-exec
reviewed
Sep 12, 2023
/// and then it relies on the high 7 bits to indicate | ||
/// that the data actually corresponds to the version. | ||
#[derive(Clone, Copy, PartialEq, Eq, Hash, Debug)] | ||
pub enum ScriptHashType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Split out Molecule generated types while providing
no-std
support tockb-std
, replacing cratesckb-standalone-types
.What is changed and how it works?
ckb-types
, named asckb-gen-types
.ckb-types
re-exportsckb-gen-types
to ensure compatibility with other crates that reference it.ckb-gen-types
comes withno-std
support and can fully replaceckb-standalone-types
, whichckb-std
relies on.ckb-gen-types
are as follows:std
types, it will be kept inckb-gen-types
and conditionally compiled with the "std" feature.ckb-gen-types
.ckb-types::core
, it will be kept inckb-types
, and a customtrait
will be placed in theprelude
to addressorphan rules
.ckb-gen-types
adds feature controls to several sub-modules in the extension, following the approach used inckb-standalone-types
to be compatible withckb-std
:calc-hash
: no-stdcheck-data
: no-stdserialized-size
: no-stdstd
: default, enables all in the std environment.ckb-contract
, has been added tockb-hash
to support compatibility withckb-std
and allow specifying the use ofblake2b-ref
, following the approach used inckb-standalone-types
.ckb-gen-types
(perhaps a better approach could be considered):ckb-std
,core::ScriptTypeHash
have been kept inckb-gen-types
.What's Changed:
Related changes
ckb-std
update for testckb-gen-types
: https://github.com/EthanYuan/ckb-std/tree/updateckb-x64-simulator
(ckb-std
's dep) update for test: https://github.com/EthanYuan/ckb-x64-simulator/tree/updateCheck List
Tests
ckb-standalone-types
withckb-gen-types
,ckb-std
passes the tests successfully.Side effects
Release note