-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx pool Replace-by-fee #4079
Merged
zhangsoledad
merged 60 commits into
nervosnetwork:tx_pool_refactor
from
chenyukang:tx_pool_rbf
Aug 17, 2023
Merged
Tx pool Replace-by-fee #4079
zhangsoledad
merged 60 commits into
nervosnetwork:tx_pool_refactor
from
chenyukang:tx_pool_rbf
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
tx_pool_rbf
branch
3 times, most recently
from
July 26, 2023 04:31
fcd4307
to
feb4728
Compare
chenyukang
force-pushed
the
tx_pool_refactor
branch
from
August 7, 2023 15:40
cc1a72c
to
a709291
Compare
quake
reviewed
Aug 11, 2023
chenyukang
force-pushed
the
tx_pool_rbf
branch
from
August 11, 2023 14:01
07f4744
to
2c9cca1
Compare
chenyukang
force-pushed
the
tx_pool_rbf
branch
from
August 11, 2023 14:07
2c9cca1
to
bc7e613
Compare
quake
reviewed
Aug 14, 2023
chenyukang
force-pushed
the
tx_pool_rbf
branch
from
August 14, 2023 08:21
488be2c
to
95e3596
Compare
chenyukang
force-pushed
the
tx_pool_rbf
branch
from
August 14, 2023 14:02
abc3329
to
0374910
Compare
chenyukang
force-pushed
the
tx_pool_rbf
branch
from
August 15, 2023 10:54
6d7c5b9
to
3e4b947
Compare
quake
approved these changes
Aug 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add feature of Replace-by-fee for
tx-pool
.Fixes #3734
What is changed and how it works?
What's Changed:
This RBF feature enables users to replace a transaction with a higher fee rate when pending in
tx-pool
, which is useful when the transaction is stuck in thetx-pool
:min_rbf_rate
inckb.toml
with default value1500
, which means the minimum extra fee rate for RBF, the unit isshannons/KB
fee
andmin_replace_fee
inget_transaction
, which means the the minimal fee need to pay for RBF for a specific transactionmin_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)
tx-pool
and with the statusRejected
.Related changes
owner/repo
:Check List
Tests
Side effects
Release note