Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix disconnect miss await #4115

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: fix disconnect miss await #4115

merged 1 commit into from
Aug 25, 2023

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Aug 24, 2023 •
edited
Loading

What problem does this PR solve?

fix disconnect miss await, it may lead to illegal node connection, but cannot be found in the node registration information

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@driftluo driftluo requested a review from a team as a code owner August 24, 2023 11:20
@driftluo driftluo requested review from quake and removed request for a team August 24, 2023 11:20
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 25, 2023
Merged via the queue into nervosnetwork:develop with commit 44d8a76 Aug 25, 2023
34 checks passed
@driftluo driftluo deleted the fix-missing-await branch August 25, 2023 09:12
@driftluo driftluo mentioned this pull request Aug 28, 2023
Merged
quake added a commit that referenced this pull request Aug 28, 2023
@quake
Merge pull request #4117 from driftluo/backport
08ff0c8 
backport #4115
@zhangsoledad zhangsoledad mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @eval-exec @zhangsoledad