Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the RPC generate_block method comments #4124

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: update the RPC generate_block method comments #4124

merged 1 commit into from
Aug 29, 2023

Conversation

EthanYuan
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

There are deprecated parameters in the comments of RPC method generate_block.

What is changed and how it works?

What's Changed:

  • removed deprecated parameters
  • added a note about concurrent calling

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

None: Exclude this PR from the release note.

@EthanYuan EthanYuan requested a review from a team as a code owner August 29, 2023 05:20
@EthanYuan EthanYuan requested review from zhangsoledad and removed request for a team August 29, 2023 05:20
@doitian doitian added this pull request to the merge queue Aug 29, 2023
Merged via the queue into nervosnetwork:develop with commit e90241b Aug 29, 2023
35 checks passed
@EthanYuan EthanYuan deleted the fix-rpc-doc branch August 29, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian doitian approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanYuan @doitian @eval-exec