Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #4575

Merged
merged 6 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion network/src/tests/peer_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ fn test_accept_inbound_peer_eviction() {
peer.connected_time = now - Duration::from_secs(10);
};
}
// thoses peers will not be protect, we add them to evict_targets
// theses peers will not be protect, we add them to evict_targets
chenyukang marked this conversation as resolved.
Show resolved Hide resolved
for _ in 0..longest_connection_time_peers_count {
let peer_addr = peers_iter.next().unwrap();
let peer_id = extract_peer_id(peer_addr).unwrap();
Expand Down
4 changes: 2 additions & 2 deletions script/src/verify/tests/ckb_latest/features_since_v2023.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ use crate::verify::{tests::utils::*, *};
// check_spawn_set_content: set_content() with content < length, = length and > length.
// check_spawn_out_of_cycles: child script out-of-cycles.
// check_spawn_exec: A exec B spawn C.
// check_spawn_strcat_wrap: A spawn B spwan C.
// check_spawn_out_of_cycles_wrap: A spawn B spwan C, but C out-of-cycles.
// check_spawn_strcat_wrap: A spawn B spawn C.
// check_spawn_out_of_cycles_wrap: A spawn B spawn C, but C out-of-cycles.
// check_spawn_recursive: A spawn A spawn A ... ... spawn A
// check_spawn_big_memory_size: fails when memory_limit > 8.
// check_spawn_big_content_length: fails when content_length > 256K.
Expand Down
2 changes: 1 addition & 1 deletion test/src/specs/sync/sync_churn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ impl Spec for SyncChurn {
let mining_node = select_random_node(&mut rng, &mut mining_nodes);
mining_node.mine(1);
// Because the test that waiting for nodes to sync has a implicit maximum waiting time
// (currently 60 seconds, we can sync about 200 blocks per second, so a maxium blocks of 10000 is reasonable)
// (currently 60 seconds, we can sync about 200 blocks per second, so a maximum blocks of 10000 is reasonable)
// and the implicit waiting time is not long enough when there are too many blocks to sync,
// so we stop mining when the tip block number is greater than 15000.
// Otherwise nodes may not be able to sync within the implicit waiting time.
Expand Down
Loading