Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix script test error caused by rand step cycles #4581

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Aug 12, 2024

What problem does this PR solve?

step_cycles is randomly generated, which may introduce different VM execution results.
cc PR #4546

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 12, 2024 14:12
@chenyukang chenyukang requested review from quake and removed request for a team August 12, 2024 14:12
quake
quake previously approved these changes Aug 13, 2024
eval-exec
eval-exec previously approved these changes Aug 13, 2024
@quake quake added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@eval-exec

This comment was marked as outdated.

@chenyukang chenyukang force-pushed the yukang-fix-script-test branch 3 times, most recently from 4d9a2a9 to f0feac9 Compare August 13, 2024 12:32
@eval-exec eval-exec enabled auto-merge August 14, 2024 06:32
@eval-exec

This comment was marked as outdated.

@eval-exec eval-exec added the t:test: Integration Test Type: This issue is related to test. label Aug 16, 2024
@chenyukang chenyukang force-pushed the yukang-fix-script-test branch from 282b04c to ccd22be Compare August 16, 2024 01:42
@eval-exec
Copy link
Collaborator

@chenyukang please rebase onto develop

@eval-exec eval-exec force-pushed the yukang-fix-script-test branch from b9a3bd5 to 2e100d8 Compare September 2, 2024 09:22
@eval-exec eval-exec added this pull request to the merge queue Sep 2, 2024
Merged via the queue into nervosnetwork:develop with commit 0274984 Sep 2, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:test: Integration Test Type: This issue is related to test.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants