Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not start BlockDownload thread if ckb has received exit signal #4615

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Do not start BlockDownload thread if ckb has received exit signal #4615

merged 1 commit into from
Aug 27, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Aug 26, 2024 •
edited
Loading

What problem does this PR solve?

Related changes

  • Do not start BlockDownload thread if ckb has received exit signal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 26, 2024 12:13
@eval-exec eval-exec requested review from quake and removed request for a team August 26, 2024 12:13
@eval-exec eval-exec closed this Aug 26, 2024
@eval-exec eval-exec reopened this Aug 26, 2024
@eval-exec eval-exec force-pushed the exec/exit-blockdownload-if-BlockFetchCMD-dropped branch from 819db43 to a04d08c Compare August 26, 2024 12:33
@eval-exec eval-exec changed the title Exit BlockDownload thread if BlockFetchCMD sender dropped Do not start BlockDownload thread if ckb has received exit signal Aug 26, 2024
@eval-exec eval-exec force-pushed the exec/exit-blockdownload-if-BlockFetchCMD-dropped branch from a04d08c to 0522ab1 Compare August 26, 2024 12:37
@eval-exec eval-exec force-pushed the exec/exit-blockdownload-if-BlockFetchCMD-dropped branch from 0522ab1 to e48f664 Compare August 26, 2024 14:19
@chenyukang chenyukang added this pull request to the merge queue Aug 27, 2024
Merged via the queue into nervosnetwork:develop with commit 7304ea7 Aug 27, 2024
32 checks passed
@chenyukang chenyukang mentioned this pull request Aug 27, 2024
Closed
@sunchengzhu sunchengzhu mentioned this pull request Aug 27, 2024
Closed
@doitian doitian mentioned this pull request Aug 28, 2024
Closed
3 tasks
@chenyukang chenyukang mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @chenyukang