Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ckb_chain::consume_unverified to ckb_chain::verify #4626

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Rename ckb_chain::consume_unverified to ckb_chain::verify #4626

merged 1 commit into from
Sep 2, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

In current develop:
The log looks like:

2024-08-30 02:31:18.961 +00:00 consume_unverified_blocks INFO ckb_chain::consume_unverified  [verify block] new best block found: 13721606 => 0x26ba9b2e2c562aecdb13042feab7c7c850bacd95748127a43167a104680b3044, difficulty diff = 0x34b5ec519ab53fc6, unverified_tip: 13721606

the ckb_chain::consume_unverified looks inappropriate. Changing it to ckb_chain::verify should be more appropriate.

Rename ckb_chain::consume_unverified to ckb_chain::verify

What is changed and how it works?

What's Changed:

Related changes

  • Change consume_unverified.rs to verify.rs in ./chain/src/

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec force-pushed the exec/rename-consume-unverified-file branch 2 times, most recently from de0741c to f4c5d97 Compare August 30, 2024 04:01
@eval-exec eval-exec marked this pull request as ready for review August 30, 2024 04:04
@eval-exec eval-exec requested a review from a team as a code owner August 30, 2024 04:04
@eval-exec eval-exec requested review from doitian and removed request for a team August 30, 2024 04:04
@eval-exec eval-exec changed the title Rename ckb_chain::consume_unverified to ckb_chain::verify Rename ckb_chain::consume_unverified to ckb_chain::verify Aug 30, 2024
@eval-exec eval-exec force-pushed the exec/rename-consume-unverified-file branch from f4c5d97 to c789b83 Compare August 30, 2024 04:05
@eval-exec eval-exec enabled auto-merge August 30, 2024 11:48
@eval-exec eval-exec added the log label Aug 30, 2024
@eval-exec eval-exec added this pull request to the merge queue Sep 2, 2024
Merged via the queue into nervosnetwork:develop with commit 4919219 Sep 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@quake quake Awaiting requested review from quake

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @chenyukang