Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): add retry for git clone in cli_test #4630

Merged
merged 1 commit into from
Sep 2, 2024
Merged

chore(test): add retry for git clone in cli_test #4630

merged 1 commit into from
Sep 2, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Sometimes git clone may fail for network issues.

What is changed and how it works?

Add a retry strategy for it.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner September 2, 2024 02:37
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team September 2, 2024 02:37
@chenyukang chenyukang added this pull request to the merge queue Sep 2, 2024
Merged via the queue into nervosnetwork:develop with commit 72b735c Sep 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyukang @eval-exec