Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small wasm support #4683

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Oct 22, 2024

What problem does this PR solve?

After some effort, the ckb-light-client project has been verified and run on the browser. It can perform basic queries and responses and can be embedded in any web page. The binary size is about 20M, but there is still some work to be verified. This PR is the basic support for WASM.

wait nervosnetwork/tentacle#375

Issues to discuss:

  • I disable the peer-store dump on WASM now load/dump peer store on wasm
  • I unimplemented soft-fork version bit get/insert on WASM now
  • I disable the network key persistence on WASM now export fn to set network key, if not set, return error

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo force-pushed the small-wasm-support branch 2 times, most recently from 7745dd2 to 7b709ad Compare October 24, 2024 03:59
network/src/peer.rs Outdated Show resolved Hide resolved
network/src/network.rs Outdated Show resolved Hide resolved
network/src/peer_store/peer_store_impl.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Oct 24, 2024
@driftluo driftluo force-pushed the small-wasm-support branch 14 times, most recently from 8ac3019 to b9635a3 Compare October 26, 2024 05:49
@driftluo driftluo force-pushed the small-wasm-support branch 2 times, most recently from 879ab46 to e75496e Compare November 13, 2024 03:41
@doitian doitian added the p:must-have Priority: critical to the current delivery timebox in order for it to be a success label Nov 18, 2024
@doitian doitian mentioned this pull request Nov 18, 2024
2 tasks
@driftluo driftluo force-pushed the small-wasm-support branch 4 times, most recently from 052e456 to e8d79f5 Compare November 18, 2024 07:11
@driftluo driftluo marked this pull request as ready for review November 18, 2024 07:57
@driftluo driftluo requested a review from a team as a code owner November 18, 2024 07:57
@driftluo driftluo requested review from doitian and removed request for a team November 18, 2024 07:57
@driftluo
Copy link
Collaborator Author

Do we need to specify a new release target in .github/workflows/package.yaml?

I don't think it's necessary, ckb itself doesn't release a wasm version

eval-exec
eval-exec previously approved these changes Nov 18, 2024
util/runtime/src/lib.rs Outdated Show resolved Hide resolved
resource/src/lib.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the small-wasm-support branch 2 times, most recently from e8aab4c to 163fb29 Compare November 25, 2024 15:10
@driftluo driftluo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into nervosnetwork:develop with commit 80cfe48 Nov 26, 2024
32 checks passed
@driftluo driftluo deleted the small-wasm-support branch November 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:must-have Priority: critical to the current delivery timebox in order for it to be a success t:enhancement Type: Feature, refactoring.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants