Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix pg sqlite inconsistent types #4709

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: fix pg sqlite inconsistent types #4709

merged 1 commit into from
Nov 13, 2024

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

Fix inconsistent mapping of PG Sqlite types in rust

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo force-pushed the fix-pg-sqlite-inconsistent-types branch from 14adffb to be617e7 Compare November 12, 2024 15:12
@driftluo driftluo marked this pull request as ready for review November 13, 2024 02:22
@driftluo driftluo requested a review from a team as a code owner November 13, 2024 02:22
@driftluo driftluo requested review from zhangsoledad and eval-exec and removed request for a team November 13, 2024 02:22
eval-exec
eval-exec approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure under what circumstances a 'pg_type' would be classified as BOOLEAN. But approve.

@driftluo driftluo added this pull request to the merge queue Nov 13, 2024
Merged via the queue into nervosnetwork:develop with commit deff22f Nov 13, 2024
32 checks passed
@driftluo driftluo deleted the fix-pg-sqlite-inconsistent-types branch November 13, 2024 03:05
@doitian doitian mentioned this pull request Nov 18, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driftluo @eval-exec