Setup onion error packet #354
Open
+260
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
force-pushed
the
feature/onion-returning-errors
branch
3 times, most recently
from
905f7c5
to
07192c9
Compare
Setup the framework to return payment error via onion error packet. The spec can be found here: https://github.com/cryptape/fiber-sphinx/blob/develop/docs/spec.md#returning-errors The encryption has not been enabled yet so I can split the changes into several PRs. The encryption can be enabled later without breaking the network protocol because the decryption phrase will check whether the error has been encrypted or not.
doitian
force-pushed
the
feature/onion-returning-errors
branch
from
07192c9
to
7b5cd90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup the framework to return payment error via onion error packet.
The spec can be found here: https://github.com/cryptape/fiber-sphinx/blob/develop/docs/spec.md#returning-errors
The encryption has not been enabled yet so I can split the changes into several PRs. The encryption can be enabled later without breaking the network protocol because the decryption phrase will check whether the error has been encrypted or not.
Refs #198