Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckb client versions #3255

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Update ckb client versions #3255

merged 1 commit into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Update versions of builtin CKB node and light client

@Keith-CY
Copy link
Collaborator

Details of hardfork on testnet: https://github.com/nervosnetwork/rfcs/blob/3a6ae4fa5d59b6e33fa7bd563d336706d135c0d8/rfcs/0051-ckb2023/0051-ckb2023.md

The main change is that a new variant(data2) of hash type is introduced, which has not been handled yet.

@Keith-CY Keith-CY self-requested a review October 30, 2024 00:25
@Keith-CY
Copy link
Collaborator

Details of hardfork on testnet: nervosnetwork/rfcs@3a6ae4f/rfcs/0051-ckb2023/0051-ckb2023.md

The main change is that a new variant(data2) of hash type is introduced, which has not been handled yet.

@Danie0918 please arrange for developers to handle the hardfork adaption

@Keith-CY Keith-CY marked this pull request as draft November 6, 2024 10:52
@github-actions github-actions bot force-pushed the update-ckb-client-versions branch 3 times, most recently from 16b05eb to 9a82bc4 Compare November 12, 2024 00:23
@Keith-CY
Copy link
Collaborator

Details of hardfork on testnet: nervosnetwork/rfcs@3a6ae4f/rfcs/0051-ckb2023/0051-ckb2023.md

The main change is that a new variant(data2) of hash type is introduced, which has not been handled yet.

It's been updated by #3264, @silySuper please have a test

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 13, 2024

/package
Packaging for test is done in 11809152428. @Keith-CY

@silySuper
Copy link
Collaborator

silySuper commented Nov 13, 2024

When send transaction to a data2 address :ckt1qrhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwupqprwx2t
it shows:
截屏2024-11-13 10 49 56
@devchenyan

@Keith-CY
Copy link
Collaborator

When send transaction to a data2 address :ckt1qrhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwupqprwx2t it shows: 截屏2024-11-13 10 49 56 @devchenyan

This is caused by the chain that not being updated to 0.119.0. But I just downloaded the test package and check the version of ckb client, it's 0.119.0

@yanguoyu
Copy link
Collaborator

When send transaction to a data2 address :ckt1qrhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwupqprwx2t it shows: 截屏2024-11-13 10 49 56 @devchenyan

I get that you start a local ckb node, do you use the 0.119.0 ckb node?https://github.com/nervosnetwork/ckb/releases/tag/v0.119.0

@silySuper
Copy link
Collaborator

OK,I use 114 to test always,because it sync totally.I will try to use 0.114 data to replace 0.119 version to verify

@silySuper
Copy link
Collaborator

Can not replace ,it will throw an error when run.
截屏2024-11-13 11 29 47

@silySuper
Copy link
Collaborator

it is syncing,and need wait about 5 hours yet.
截屏2024-11-13 15 39 16

@silySuper
Copy link
Collaborator

silySuper commented Nov 14, 2024

Node sync has bug
nervosnetwork/ckb#4713

@Keith-CY
Copy link
Collaborator

[email protected] is expected to publish on 2024-11-25, no breaking changes will be introduced so we can hold this update until [email protected] goes live.
Tests based on 0.119.0 can be continued because 0.120.0 doesn't have breaking changes.
Ref: nervosnetwork/ckb#4715

@Keith-CY
Copy link
Collaborator

How is test going @silySuper

@silySuper
Copy link
Collaborator

1.In send page,price is abnormal
截屏2024-11-20 11 10 18

2.A transaction which has on chain,but not show in neuron.tx id:0xbebc86ca51aff3a757cf1b3230d3acbc8bbc44adf4da715d05832bac38c834d8

https://testnet.explorer.nervos.org/transaction/0xbebc86ca51aff3a757cf1b3230d3acbc8bbc44adf4da715d05832bac38c834d8

截屏2024-11-20 11 15 00

@Keith-CY
Copy link
Collaborator

1.In send page,price is abnormal 截屏2024-11-20 11 10 18

2.A transaction which has on chain,but not show in neuron.tx id:0xbebc86ca51aff3a757cf1b3230d3acbc8bbc44adf4da715d05832bac38c834d8

testnet.explorer.nervos.org/transaction/0xbebc86ca51aff3a757cf1b3230d3acbc8bbc44adf4da715d05832bac38c834d8

截屏2024-11-20 11 15 00

All available price options are 1000 shannons/kB, which is abnormal.
When Neuron fails to fetch fee rate data from the node, there should be 3 different fee rates set in Neuron.
When Neuron fetches fee rate data from the node, the median won't be 1000 shannons/kB

@silySuper
Copy link
Collaborator

How is test going @silySuper

Firstly find out node sync has problem which cause sync stop in node data-network file with tester gp,now node sync it is normal now.

@Keith-CY
Copy link
Collaborator

How is test going @silySuper

Firstly find out node sync has problem which cause sync stop in node data-network file with tester gp,now node sync it is normal now.

But the price options are not expected to be the same even when the node is abnormal, please have a check @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Nov 20, 2024

How is test going @silySuper

Firstly find out node sync has problem which cause sync stop in node data-network file with tester gp,now node sync it is normal now.

But the price options are not expected to be the same even when the node is abnormal, please have a check @yanguoyu

yes, whether node is normal or abnormal here should show different price

@silySuper
Copy link
Collaborator

Why send transaction always be rejected only can be solved by adjust amount or fee now?
2024-11-19_17 25 27

@yanguoyu
Copy link
Collaborator

How is test going @silySuper

Firstly find out node sync has problem which cause sync stop in node data-network file with tester gp,now node sync it is normal now.

But the price options are not expected to be the same even when the node is abnormal, please have a check @yanguoyu

image

I tried get_fee_rate_statistics for about 4 minutes, most of the time, the media of get_fee_rate_statistics is 0x3e8='1000', so the suggestion fee is 1000.
The Slow and Fast fees are calculated by the media fee, https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-ui/src/components/PricePanel/index.tsx#L142 is the calculated way. When the media is 1000, Slow and Fast will be 1000, should we change the calculated way?

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 20, 2024

How is test going @silySuper

Firstly find out node sync has problem which cause sync stop in node data-network file with tester gp,now node sync it is normal now.

But the price options are not expected to be the same even when the node is abnormal, please have a check @yanguoyu

Confirmed that fee rate options 1000/1000/1000 are correct, it comes from the on-chain data.

@silySuper
Copy link
Collaborator

ok,i am looking with gp at can not sync problem.
截屏2024-11-20 16 25 24

@silySuper
Copy link
Collaborator

When backup data can be used? @Ops-NoardGuo

@guomaoqiu
Copy link

When backup data can be used? @Ops-NoardGuo

I just contacted ckb dev to review our backup test strategy and found some problems. We are re-doing the backup, which will take a few hours. I will let you know after the backup is completed and tested.

@guomaoqiu
Copy link

When backup data can be used? @Ops-NoardGuo

I just contacted ckb dev to review our backup test strategy and found some problems. We are re-doing the backup, which will take a few hours. I will let you know after the backup is completed and tested.

After testing the backup data is now available and the download method has been sent to you. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Nov 22, 2024

1.Data2 single sign is invalid.

2024-11-22.17.09.46.mov

@devchenyan

@silySuper
Copy link
Collaborator

Sync throws error again now.I am finding with tester gp.

@yanguoyu
Copy link
Collaborator

yanguoyu commented Nov 25, 2024

/package
Packaging for test is done in 12004894706. @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Nov 25, 2024

ckt1qrhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwamhwupqprwx2t

Please check the No.2 problem which may cause my transaction pending. @devchenyan

@silySuper
Copy link
Collaborator

I transfer a spore to my data2 address which was created by my neuron address successfully,but i can not see this record in my history.
browser has this transaction:
https://testnet.explorer.nervos.org/transaction/0x9aef7faf0a6b0fec16cf4b21f9a4be61099eebcc39e94f855532f1fd893be88e
截屏2024-11-26 14 57 45

my data2 address:
ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwspy3zv02drg4aftwgv6szcs8wcc8fazjvwgvqqffj

@silySuper
Copy link
Collaborator

verified

@Keith-CY Keith-CY marked this pull request as ready for review November 28, 2024 08:58
@Keith-CY
Copy link
Collaborator

[email protected] has been delayed for days, let's release Neuron with [email protected] first.

@yanguoyu @homura @devchenyan
And please add an approval if all tests are green @silySuper

@homura
Copy link
Collaborator

homura commented Nov 29, 2024

[email protected] has been delayed for days, let's release Neuron with [email protected] first.

Have these two commits been overridden?

#3264
#3267

@Keith-CY
Copy link
Collaborator

[email protected] has been delayed for days, let's release Neuron with [email protected] first.

Have these two commits been overridden?

#3264 #3267

They are not related to [email protected]. Hardfork has been introduced since [email protected], but [email protected] was expected to be released in the past few days, so we've held on to it.

@homura
Copy link
Collaborator

homura commented Nov 29, 2024

They are not related to [email protected]. Hardfork has been introduced since [email protected], but [email protected] was expected to be released in the past few days, so we've held on to it.

The two PRs introduce data2 to support the hard fork introduced in version 0.119, and this PR is for 0.119. Is there something I missed?

@Keith-CY
Copy link
Collaborator

They are not related to [email protected]. Hardfork has been introduced since [email protected], but [email protected] was expected to be released in the past few days, so we've held on to it.

The two PRs introduce data2 to support the hard fork introduced in version 0.119, and this PR is for 0.119. Is there something I missed?

Your understanding is correct. This release was originally planned for [email protected], but since [email protected] was about to be released and didn't require Neuron adaptation, we decided to go straight ahead and bundle [email protected] directly.

Now we will ship Neuron with [email protected] first.

@Keith-CY Keith-CY merged commit 210b83e into develop Nov 29, 2024
@Keith-CY Keith-CY deleted the update-ckb-client-versions branch November 29, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants