-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bouhadjar sequence learning network tutorial #1026
base: master
Are you sure you want to change the base?
Conversation
Bencher Report
Click to view all benchmark results
|
It seems as though the second line in the following snippet from the notebook causes an extreme memory consumption: connections = nest.GetConnections(synapse_model=...)
connections.set({'Wmin': connections.weight}) There are around 165000 connections. Edit: spun off to nest/nest-simulator#3359. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this excellent tutorial! I have a few minor comments:
- When you describe the different terms in the STDP rule in the text, could you refer to the equation by number? For example, the second term on the right-hand side in (1)...
- Any reason behind setting the number of threads to 1?
- Under "Generating code with NESTML", do we need the
try
andexcept
?- Remove the following lines
"""module_name = "/tmp/nestml_target_68digoes/nestml_27fd8d9de14b408f9e6181b2f2310d41_module.so"
neuron_model_name = "iaf_psc_exp_nonlineardendrite_neuron_nestml__with_stdsp_synapse_nestml"
synapse_model_name = "stdsp_synapse_nestml__with_iaf_psc_exp_nonlineardendrite_neuron_nestml" """
- The fig just before
Experiment 2
is a bit hard to read. Can the three panels be a bit further apart?
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
@pnbabu: much obliged for the review! I have cleaned up the notebook and the neuron model; this should address all your comments. |
Should be merged after #1027.