Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid sympy 1.10.* due to upstream issue with autowrap #59

Merged
merged 5 commits into from
May 5, 2022

Conversation

clinssen
Copy link
Contributor

Temporary fix for #58.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #59 (2a4985f) into master (bb71b0a) will decrease coverage by 19.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
- Coverage   82.60%   63.39%   -19.21%     
===========================================
  Files          25       25               
  Lines        1937     1937               
===========================================
- Hits         1600     1228      -372     
- Misses        337      709      +372     
Impacted Files Coverage Δ
odetoolbox/stiffness.py 0.00% <0.00%> (-85.90%) ⬇️
odetoolbox/mixed_integrator.py 11.29% <0.00%> (-62.91%) ⬇️
tests/test_stiffness.py 37.83% <0.00%> (-56.76%) ⬇️
tests/test_expression_simplification.py 45.00% <0.00%> (-55.00%) ⬇️
tests/test_mixed_integrator_numeric.py 30.30% <0.00%> (-42.43%) ⬇️
odetoolbox/spike_generator.py 57.44% <0.00%> (-40.43%) ⬇️
odetoolbox/sympy_printer.py 61.90% <0.00%> (-23.81%) ⬇️
odetoolbox/__init__.py 67.59% <0.00%> (-20.84%) ⬇️
tests/test_analysis_mixed_analytic_numerical.py 79.31% <0.00%> (-17.25%) ⬇️
odetoolbox/system_of_shapes.py 85.42% <0.00%> (-4.53%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb71b0a...2a4985f. Read the comment docs.

@clinssen clinssen force-pushed the sympy_disable_broken_version branch from aef59d8 to 92ccf15 Compare April 25, 2022 14:06
@clinssen clinssen force-pushed the sympy_disable_broken_version branch from 92ccf15 to f79b501 Compare April 25, 2022 15:04
@clinssen clinssen requested a review from pnbabu May 3, 2022 09:51
@clinssen clinssen requested a review from pnbabu May 4, 2022 19:12
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pnbabu pnbabu merged commit 701f469 into nest:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants