fix: typings for fastify enableCors
method
#13247
Open
+36
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify adapter uses typings from
@fastify/cors
package forenableCors
methodFix #13234
PR Checklist
Please check if your PR fulfills the following requirements:
Docs have been added / updated (for bug fixes / features)I do not think it is needed, documentation already refers to@fastfy/cors
optionsPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13234
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I'm not sure I've got the architecture right. My understanding is that the adapter should be platform-independent, and if there is a platform-specific implementation of the adapter then not. I took inspiration from
useStaticAssets
method for example, i.e. a universal adapter hasany
types and then the individual types are applied to the adapter (fastify, express) implementations.