Enable analyzers and add a editorconfig #3159
ci_build.yml
on: pull_request
🔨 Build sources (CI)
3m 44s
Annotations
1 error and 11 warnings
🔨 Build sources (CI)
; expected
|
🔨 Build sources (CI)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/Exceptions/MqttConnectionException.cs#L6
public MqttConnectionException() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1032) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/Exceptions/MqttPublishException.cs#L6
public MqttPublishException() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1032) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/Helpers/EntityIdParser.cs#L18
Method Extract passes parameter name 'entityId' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/MessageSender.cs#L63
The logging message template should not vary between calls to 'LoggerExtensions.LogError(ILogger, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2254) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/MqttEntityManager.cs#L155
Member 'IsAvailabilityTopicRequired' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/AssuredMqttConnection.cs#L89
The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'AssuredMqttConnection.BuildErrorResponse(MqttClientDisconnectedEventArgs)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/AssuredMqttConnection.cs#L16
Unused field 'RetryMaximumSeconds' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Common/Attributes/JetBrainsCodeAnnotations.cs#L96
The enum member 'Itself' has the same constant value '1' as member 'Default' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1069) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/Compiler/CompileSettings.cs#L8
Member 'UseDebug' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/Context/ApplicationContext.cs#L5
Type 'ApplicationContext' owns disposable field(s) '_cancelTokenSource' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|