.NET 8 version 4 release #3195
ci_build.yml
on: pull_request
🔨 Build sources (CI)
3m 5s
Annotations
1 error and 11 warnings
🔨 Build sources (CI)
; expected
|
🔨 Build sources (CI)
The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
🔨 Build sources (CI):
src/Extensions/NetDaemon.Extensions.MqttEntityManager/MessageSubscriber.cs#L107
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854) [/home/runner/work/netdaemon/netdaemon/src/Extensions/NetDaemon.Extensions.MqttEntityManager/NetDaemon.Extensions.MqttEntityManager.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/AppAssemblyProviders/IAppAssemblyProvider.cs#L5
Missing XML comment for publicly visible type or member 'IAppAssemblyProvider' [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/AppAssemblyProviders/IAppAssemblyProvider.cs#L7
Missing XML comment for publicly visible type or member 'IAppAssemblyProvider.GetAppAssembly()' [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Common/Attributes/JetBrainsCodeAnnotations.cs#L96
The enum member 'Itself' has the same constant value '1' as member 'Default' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1069) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/Context/ApplicationContext.cs#L5
Type 'ApplicationContext' owns disposable field(s) '_cancelTokenSource' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/AppModel/NetDaemon.AppModel/Internal/Config/ConfigurationBinding.cs#L388
Change return type of method 'GetAllProperties' from 'System.Collections.Generic.IEnumerable<System.Reflection.PropertyInfo>' to 'System.Collections.Generic.List<System.Reflection.PropertyInfo>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859) [/home/runner/work/netdaemon/netdaemon/src/AppModel/NetDaemon.AppModel/NetDaemon.AppModel.csproj]
|
🔨 Build sources (CI):
src/Client/NetDaemon.HassClient/Common/Exceptions/HomeAssistantApiCallException.cs#L6
Change the base type of NetDaemon.Client.Internal.Exceptions.HomeAssistantApiCallException so that it no longer extends System.ApplicationException. This base exception type does not provide any additional value for framework classes. Extend 'System.Exception' or an existing unsealed exception type instead. Do not create a new exception base type unless there is specific value in enabling the creation of a catch handler for an entire class of exceptions. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1058) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
|
🔨 Build sources (CI):
src/Client/NetDaemon.HassClient/Internal/Helpers/AsyncLazy.cs#L6
Do not create tasks without passing a TaskScheduler (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2008) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
|
🔨 Build sources (CI):
src/Client/NetDaemon.HassClient/Internal/Helpers/HttpHelper.cs#L20
Change return type of method 'CreateHttpMessageHandler' from 'System.Net.Http.HttpMessageHandler' to 'System.Net.Http.HttpClientHandler' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
|
🔨 Build sources (CI):
src/Client/NetDaemon.HassClient/Internal/Helpers/ResultMessageHandler.cs#L8
'ResultMessageHandler' contains field '_tokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'ResultMessageHandler' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
|