Skip to content

Bump JoySoftware.NetDaemon.Extensions.Logging from 23.38.0 to 23.43.0 #3209

Bump JoySoftware.NetDaemon.Extensions.Logging from 23.38.0 to 23.43.0

Bump JoySoftware.NetDaemon.Extensions.Logging from 23.38.0 to 23.43.0 #3209

Triggered via pull request October 26, 2023 23:43
Status Failure
Total duration 1m 41s
Artifacts

ci_build.yml

on: pull_request
🔨 Build sources (CI)
1m 29s
🔨 Build sources (CI)
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 11 warnings
NetDaemon.HassClient.Tests.HelperTest.ResultMessageHandlerTests.TestTaskCompleteWithErrorResultShouldLogWarning: src/Client/NetDaemon.HassClient.Tests/HelperTest/ResultMessageHandlerTests.cs#L33
Moq.MockException : Expected invocation on the mock at least once, but was never performed: x => x.Log<It.IsAnyType>(It.Is<LogLevel>(l => (int)l == 3), It.IsAny<EventId>(), It.Is<It.IsAnyType>((v, t) => state(v, t)), It.IsAny<Exception>(), It.Is<Func<It.IsAnyType, Exception, string>>((v, t) => True)) Performed invocations: Mock<ILogger<ResultMessageHandler>:3> (x): ILogger.Log<FormattedLogValues>(LogLevel.Warning, 0, Failed command (test) error: (null). Sent command is CommandMessage { Type = test, Id = 0 }, null, Func<FormattedLogValues, Exception, string>)
🔨 Build sources (CI)
Process completed with exit code 1.
🔨 Build sources (CI)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Common/Exceptions/HomeAssistantApiCallException.cs#L6
Change the base type of NetDaemon.Client.Internal.Exceptions.HomeAssistantApiCallException so that it no longer extends System.ApplicationException. This base exception type does not provide any additional value for framework classes. Extend 'System.Exception' or an existing unsealed exception type instead. Do not create a new exception base type unless there is specific value in enabling the creation of a catch handler for an entire class of exceptions. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1058) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Helpers/AsyncLazy.cs#L6
Do not create tasks without passing a TaskScheduler (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2008) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Net/WebSocketTransportPipeline.cs#L14
'WebSocketClientTransportPipeline' contains field '_internalCancelSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'WebSocketClientTransportPipeline' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Helpers/ResultMessageHandler.cs#L8
'ResultMessageHandler' contains field '_tokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'ResultMessageHandler' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L51
Do not create tasks without passing a TaskScheduler (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2008) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Net/WebSocketClientImpl.cs#L62
Member 'ReceiveAsync' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L131
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L132
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L136
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L13
'HomeAssistantConnection' contains field '_hassMessageSubject' that is of IDisposable type 'Subject<HassMessage>', but it is never disposed. Change the Dispose method on 'HomeAssistantConnection' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]