Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetDaemon 5, .NET 9 release #1206

Merged
merged 7 commits into from
Nov 24, 2024
Merged

NetDaemon 5, .NET 9 release #1206

merged 7 commits into from
Nov 24, 2024

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Nov 17, 2024

Proposed change

Yay! It is that time of the year when the .NET community can benefit from more innovations and more performant .NET based solutions. This PR upgrades the NetDaemon to version 5 and support .NET 9. As usual for a new .NET version we also increment the NetDaemon main version. After this PR is merged, all new features and fixes will be in this version.
TODO in this PR:

  • Update builds and github actions
  • Update the docker base images
  • Update to use C# 13
  • Upgrade to .NET dependencies
  • Manual testing by releasing an alpha release

Other todo in other repos

  • Add new addon for version 5 and .net 9
  • Update the cli tool to use .net 9
  • Update docs where it references .net 8 and change to .net 9

Breaking change

Except for new dependecy on .NET 9 SDK, code should be compatible. Please install .NET 9 SDK before using this version or use the .NET 9 docker/add-on versions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

@helto4real helto4real marked this pull request as draft November 17, 2024 16:05
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (95f2e5b) to head (e186c2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ssModel.CodeGenerator/Extensions/TypeExtensions.cs 0% 0 Missing and 2 partials ⚠️
...Daemon.Extensions.Scheduling/NetDaemonScheduler.cs 75% 0 Missing and 1 partial ⚠️
...el/NetDaemon.HassModel.CodeGenerator/Controller.cs 0% 1 Missing ⚠️
...sModel/NetDeamon.HassModel/Entities/EntityState.cs 0% 1 Missing ⚠️
...l/NetDeamon.HassModel/Internal/EntityStateCache.cs 75% 0 Missing and 1 partial ⚠️
...l/NetDeamon.HassModel/Internal/HassObjectMapper.cs 96% 0 Missing and 1 partial ⚠️
...l/NetDeamon.HassModel/StateObservableExtensions.cs 50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1206   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       196     196           
  Lines      3851    3849    -2     
  Branches    430     426    -4     
====================================
  Hits       3167    3167           
+ Misses      517     516    -1     
+ Partials    167     166    -1     
Flag Coverage Δ
unittests 82% <88%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@helto4real helto4real marked this pull request as ready for review November 23, 2024 22:45
@helto4real helto4real merged commit 4504005 into main Nov 24, 2024
7 checks passed
@helto4real helto4real deleted the ND-V5-net9 branch November 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant