Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --no-symbols so that symbol packages are pushed #933

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

Barsonax
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (68848b4) 80.13% compared to head (f832f10) 80.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #933      +/-   ##
==========================================
- Coverage   80.13%   80.10%   -0.03%     
==========================================
  Files         174      174              
  Lines        3443     3443              
  Branches      441      441              
==========================================
- Hits         2759     2758       -1     
- Misses        501      502       +1     
  Partials      183      183              
Flag Coverage Δ
unittests 80.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Barsonax Barsonax force-pushed the DoNotIgnoreSymbolsOnPush branch from 5d616fe to f832f10 Compare September 24, 2023 10:19
@Barsonax Barsonax merged commit 32eceb4 into dev Sep 24, 2023
5 of 6 checks passed
@Barsonax Barsonax deleted the DoNotIgnoreSymbolsOnPush branch September 24, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants