Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all entity methods to the IEntityCore interface #944

Closed

Conversation

x00Pavel
Copy link
Contributor

@x00Pavel x00Pavel commented Sep 28, 2023

Breaking change

Proposed change

All methods and class attributes are moved to IEntityCore interface to have ability for external libraries access these methods and attributes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@FrankBakkerNl
Copy link
Contributor

These methods were deliberately not added to this interface

Copy link
Contributor

@FrankBakkerNl FrankBakkerNl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intended

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e3a8726) 80.10% compared to head (91d03ad) 80.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #944      +/-   ##
==========================================
- Coverage   80.10%   80.04%   -0.06%     
==========================================
  Files         174      174              
  Lines        3443     3443              
  Branches      441      441              
==========================================
- Hits         2758     2756       -2     
- Misses        502      503       +1     
- Partials      183      184       +1     
Flag Coverage Δ
unittests 80.04% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/HassModel/NetDeamon.HassModel/Entities/Entity.cs 81.25% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity methods are no accessable in external libraries via interfaces
4 participants