Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate version of nugets and nd-codegen match #945

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Sep 30, 2023

Proposed change

The nd-codegen tool now logs a warning if the version of the tool does not match the version of the installed NetDaemon Nuget Packages

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@FrankBakkerNl FrankBakkerNl changed the title codegen_validate_refs Validate version of nugets and nd-codegen match Sep 30, 2023
@Barsonax Barsonax self-requested a review September 30, 2023 20:08
Copy link
Contributor

@Barsonax Barsonax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice idea!

@FrankBakkerNl FrankBakkerNl enabled auto-merge (squash) September 30, 2023 20:17
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (e3a8726) 80.10% compared to head (368b07b) 79.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #945      +/-   ##
==========================================
- Coverage   80.10%   79.44%   -0.66%     
==========================================
  Files         174      175       +1     
  Lines        3443     3469      +26     
  Branches      441      449       +8     
==========================================
- Hits         2758     2756       -2     
- Misses        502      529      +27     
- Partials      183      184       +1     
Flag Coverage Δ
unittests 79.44% <6.89%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n.HassModel.CodeGenerator/Helpers/VersionHelper.cs 28.57% <100.00%> (ø)
...Model/NetDaemon.HassModel.CodeGenerator/Program.cs 0.00% <0.00%> (ø)
...mon.HassModel.CodeGenerator/DependencyValidator.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably fix those linting errors at some point but that can be done in a separate PR

Good job on this one!

@helto4real helto4real disabled auto-merge October 1, 2023 06:27
@helto4real helto4real merged commit c44b02e into net-daemon:dev Oct 1, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have nd-codegen check the version of installed NetDaemon.HassModel nuget match that of the tool
3 participants