Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky internal integration test #946

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Fix flaky internal integration test #946

merged 1 commit into from
Oct 1, 2023

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Oct 1, 2023

Breaking change

Proposed change

Fix the flaky test by adding a delay to the test before sending event after subscribing to the event.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c44b02e) 79.44% compared to head (97159fd) 79.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #946      +/-   ##
==========================================
+ Coverage   79.44%   79.53%   +0.08%     
==========================================
  Files         175      175              
  Lines        3469     3469              
  Branches      449      449              
==========================================
+ Hits         2756     2759       +3     
+ Misses        529      527       -2     
+ Partials      184      183       -1     
Flag Coverage Δ
unittests 79.53% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankBakkerNl FrankBakkerNl merged commit f857f46 into dev Oct 1, 2023
6 of 7 checks passed
@FrankBakkerNl FrankBakkerNl deleted the fix_flaky_test branch October 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants