Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alot of warnings #956

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix alot of warnings #956

merged 1 commit into from
Oct 19, 2023

Conversation

Barsonax
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (00e7172) 79.50% compared to head (2ef0c8a) 79.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #956      +/-   ##
==========================================
- Coverage   79.50%   79.13%   -0.37%     
==========================================
  Files         175      175              
  Lines        3469     3485      +16     
  Branches      449      449              
==========================================
  Hits         2758     2758              
- Misses        528      544      +16     
  Partials      183      183              
Flag Coverage Δ
unittests 79.13% <31.03%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...del/NetDaemon.AppModel/Internal/AppModelContext.cs 100.00% <100.00%> (ø)
...emon.AppModel/Internal/Compiler/CompileSettings.cs 100.00% <100.00%> (ø)
...nternal/Config/Yaml/YamlConfigurationFileParser.cs 89.36% <100.00%> (ø)
...ppModel/NetDaemon.AppModel/Internal/FocusFilter.cs 71.42% <100.00%> (ø)
...t/NetDaemon.HassClient/Common/Settings/Settings.cs 100.00% <100.00%> (ø)
...tDaemon.HassClient/Internal/HomeAssistantClient.cs 84.28% <100.00%> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 87.50% <ø> (ø)
...nsions.MqttEntityManager/Helpers/EntityIdParser.cs 100.00% <100.00%> (ø)
....Extensions.MqttEntityManager/MqttEntityManager.cs 95.00% <ø> (ø)
...e/NetDaemon.Runtime/Internal/AppStateRepository.cs 84.84% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of fixes man
Thanks!

@helto4real helto4real merged commit c86c5b3 into dev Oct 19, 2023
4 of 7 checks passed
@helto4real helto4real deleted the FixWarnings branch October 19, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants