Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #18045: Enable adding a new MAC to an interface via quick add #18200

Open
wants to merge 2 commits into
base: feature
Choose a base branch
from
Open

Closes #18045: Enable adding a new MAC to an interface via quick add #18200

wants to merge 2 commits into from

Conversation

jeremystretch
Copy link
Member

Fixes: #18045

  • Move the primary_mac_address field from InterfaceCommonForm to the device & VM interface forms
  • Introduce the quick_add_params keyword argument on DynamicModelChoiceMixin
  • Alter APISelect to set quick-add parameters on the widget (rather than passing as widget attrs) & expose them as template context

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Dec 12, 2024
@jeremystretch jeremystretch force-pushed the 18045-mac-address-quick-add branch from 3ce6f90 to 8bf7e90 Compare December 12, 2024 17:32
@jeremystretch jeremystretch marked this pull request as ready for review December 12, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bctiemann bctiemann bctiemann approved these changes

Assignees
No one assigned
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @bctiemann