Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a promise warning #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lelandcope
Copy link

Fixes a promise warning because nothing is being returned.

Actual message: Warning: a promise was created in a handler but was not returned from it

Stack Trace

Warning: a promise was created in a handler but was not returned from it
  at process._tickDomainCallback (node.js:486:13)
  at process.wrappedFunction (/Users/leland/Sites/ListReports/portal/node_modules/newrelic/lib/transaction/tracer/index.js:250:51)
From previous event:
  at Promise.wrappedFunction [as _then] (/Users/leland/Sites/ListReports/portal/node_modules/newrelic/lib/transaction/tracer/index.js:225:51)
  at Model.tableReady (/Users/leland/Sites/ListReports/portal/node_modules/thinky/lib/model.js:215:34)
  at Function.Model.new (/Users/leland/Sites/ListReports/portal/node_modules/thinky/lib/model.js:167:11)
  at Thinky.createModel (/Users/leland/Sites/ListReports/portal/node_modules/thinky/lib/thinky.js:130:24)

Fixes a promise warning because nothing is being returned.

Actual message: `Warning: a promise was created in a handler but was not returned from it`
@neumino
Copy link
Owner

neumino commented Jun 11, 2016

Hum, I'm not sure you are fixing the appropriate thing.

Thinky is still using bluebird 2.x, so it doesn't warn about this. There's also no promise created where you added a return null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants