Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 2 RNN fix #25

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Tutorial 2 RNN fix #25

merged 3 commits into from
Jan 19, 2024

Conversation

aribenjamin
Copy link
Collaborator

Hi! This includes the following changes:

  • Plotting routine bugfix (wrong axes)
  • In SimpleRNN, the nonlinearity is applied earlier (to make the variable firing_rates), and also the readout is from the firing rates
  • The definition of dynamic_reg is changed to better match the paper
  • To better match the paper's hyperparameters, the regularizers are divided by C and N ( hidden_size /num_conditions )
  • Adam is changed to use no weight decay (which doubles up L2 reg)
  • The definition of rectified_tanh is corrected.

With these changes the traces for SimpleRNN look like this:
image

@SamueleBolotta SamueleBolotta merged commit ec74ba8 into main Jan 19, 2024
1 check failed
@SamueleBolotta SamueleBolotta deleted the W1D1_Tutorial2_RNNfix branch April 19, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants