feat: airdrop transfer contract #ntrn-116 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/implement-contract
branch
2 times, most recently
from
3389c25 to
80b6a38
Compare
NeverHappened
force-pushed
the
feat/implement-contract
branch
from
80b6a38 to
23489f6
Compare
pr0n00gler
requested changes
Oct 10, 2023
pr0n00gler
requested changes
Oct 10, 2023
There was a problem hiding this comment.
What's the flow if Error/Timeout happens during IBC transfer / ICA execution?
Like, in case of ICA execution timeout, an underlying channel for ICA will be closed.
How to recover it?
As far as i see, there is no way to recover an ICA via a usual call if RegisterICA method, since the contract doesn't allow it, because the registering phase is passed.
What will happen if IBC transfer fails?
pr0n00gler
requested changes
Oct 13, 2023
|
Also please attach |
* tmp: add integration tests * fix: fix * fix tests * ignore cosmopark file * tmp * kek * tests run * add gaia client for tests * review fixes * add waitResult * tests almost pass * fix tests * add incorrect stage checks * finish tests * remove old manual tests --------- Co-authored-by: Sergey Ratiashvili <[email protected]>
NeverHappened
added a commit
that referenced
this pull request
Oct 17, 2023
This reverts commit c5b82cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hadronlabs.atlassian.net/browse/NTRN-116
How to run integration tests:
make buildyarnyarn test