-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cosmwasm to 2.0 #NTRN-302 #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also same thing about backtraces
Cargo.toml
Outdated
@@ -13,21 +13,21 @@ incremental = false | |||
overflow-checks = true | |||
|
|||
[workspace.dependencies] | |||
neutron-sdk = { package = "neutron-sdk", git = "https://github.com/neutron-org/neutron-sdk", branch = "main" } | |||
neutron-sdk = { package = "neutron-sdk", git = "https://github.com/neutron-org/neutron-sdk", rev = "33e0cb123a4a91a37eb0688a8fd9b52bce320ed9" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rev needs to be updated to the latest rev of neutron-org/neutron-sdk#147 I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
contracts/dex_stargate/Cargo.toml
Outdated
cosmwasm-std = { version = "1.4.0", features = ["stargate"] } | ||
cw2 = "1.1.1" | ||
cosmwasm-std = { version = "2.0.4", features = ["stargate"] } | ||
cw2 = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please set the version to workspace for consistency (I think we're safe to do so?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see cw2
, cw-storage-plus
and cosmwasm-schema
versions inconsistency across the project, some of them are still of 1.x
versions. since we're bumping cosmwasm to a new major version, please set them all to workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had the same idea. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding 1.x
versions: there is only one contract left (balance-tracker
) with deps of such versions and, unfortunately, it is impossible to update its cosmwasm deps until astroport
updates its cosmwasm-std
Task: https://hadronlabs.atlassian.net/browse/NTRN-302
Related PRs:
neutron-org/neutron-sdk#147