Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cosmwasm to 2.0 #NTRN-302 #54

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Conversation

joldie777
Copy link
Contributor

@joldie777
Copy link
Contributor Author

@joldie777 joldie777 changed the base branch from feat/sdk-50 to main June 13, 2024 10:09
@joldie777 joldie777 changed the title feat: update cosmwasm to 2.0 feat: update cosmwasm to 2.0 #NTRN-302 Jun 13, 2024
@joldie777
Copy link
Contributor Author

Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also same thing about backtraces

Cargo.toml Outdated
@@ -13,21 +13,21 @@ incremental = false
overflow-checks = true

[workspace.dependencies]
neutron-sdk = { package = "neutron-sdk", git = "https://github.com/neutron-org/neutron-sdk", branch = "main" }
neutron-sdk = { package = "neutron-sdk", git = "https://github.com/neutron-org/neutron-sdk", rev = "33e0cb123a4a91a37eb0688a8fd9b52bce320ed9" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rev needs to be updated to the latest rev of neutron-org/neutron-sdk#147 I suppose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 37 to 36
cosmwasm-std = { version = "1.4.0", features = ["stargate"] }
cw2 = "1.1.1"
cosmwasm-std = { version = "2.0.4", features = ["stargate"] }
cw2 = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set the version to workspace for consistency (I think we're safe to do so?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see cw2, cw-storage-plus and cosmwasm-schema versions inconsistency across the project, some of them are still of 1.x versions. since we're bumping cosmwasm to a new major version, please set them all to workspace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same idea. Will do.

Copy link
Contributor Author

@joldie777 joldie777 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding 1.x versions: there is only one contract left (balance-tracker) with deps of such versions and, unfortunately, it is impossible to update its cosmwasm deps until astroport updates its cosmwasm-std

@pr0n00gler pr0n00gler merged commit 5c64652 into main Jul 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants