Feat: cw dex bindings

[pr0n00gler]

The aim of the PR is to implement binding cosmwasm interface for dex module messages and queries.
I've implemented binding adapters https://github.com/neutron-org/neutron/blob/feat/cw-dex-bindings/x/dex/types/wasm.go. The purpose of the adapters to update original dex types: expiration_time changed from Timetamp to u64 unixtime, some field names converted to snake_case.
related PRs:
neutron-org/neutron-sdk#120
neutron-org/neutron-dev-contracts#34
neutron-org/neutron-integration-tests#240
neutron-org/neutronjsplus#24

[sotnikov-s]

why don't reuse *types.MsgPlaceLimitOrder? bc of the ExpirationTime format?

[sotnikov-s]

I don't really like the copy+paste from proto file with subtle changes made: on proto updates, we'll have to manually reflect the changes in such copy+pasted structures. what do you think about making kind of wrapper structs for each struct where we replace time.Time with uint64 and implementing a simple custom UnmarshalJSON method for them. rough example (compiles but not sure that works):

type QueryEstimatePlaceLimitOrderRequest dextypes.QueryEstimatePlaceLimitOrderRequest

func (r *QueryEstimatePlaceLimitOrderRequest) MarshalJSON() ([]byte, error) {
	type Alias dextypes.QueryEstimatePlaceLimitOrderRequest
	return json.Marshal(&struct {
		ExpirationTime int64 `json:"expiration_time"`
		*Alias
	}{
		ExpirationTime: r.ExpirationTime.Unix(),
		Alias:          (*Alias)(r),
	})
}

func (r *QueryEstimatePlaceLimitOrderRequest) UnmarshalJSON(data []byte) error {
	type Alias dextypes.QueryEstimatePlaceLimitOrderRequest
	aux := &struct {
		ExpirationTime int64 `json:"expiration_time"`
		*Alias
	}{
		Alias: (*Alias)(r),
	}
	if err := json.Unmarshal(data, &aux); err != nil {
		return err
	}
	expirationTime := time.Unix(aux.ExpirationTime, 0)
	r.ExpirationTime = &expirationTime
	return nil
}

The point is if we ever change the proto e.g. add/remove fields, change some fields type, etc, we won't have to reflect the changes here in the copy+pasted structure. it will work under the hood because of the Alias auxiliary type.

custom unmarshal JSON guide: https://choly.ca/post/go-json-marshalling/

[sotnikov-s]

"%T execution completed", handler

must be msg instead, right?

[sotnikov-s]

let's make a Wrapf here with msg's %T printed as well

[sotnikov-s]

would be nice and clean to use a switch statement here for msg cases just as you did for queries

[sotnikov-s]

guys please update the PR's description with some explanation and links to related PRs

[sotnikov-s]

let's consider having the OrderType type as string and then handled the same way as here:

neutron/x/dex/client/cli/tx_place_limit_order.go

Line 47 in e605ed3

orderTypeInt, ok := types.LimitOrderType_value[args[5]]

reasoning is raw types.LimitOrderType at user's side is represented as numbers (0, 1, 2, 3 or 4, proof). would be better to expect concrete string values and compare them to the enumerated string values

[pr0n00gler]

I can't approve the PR since explicitly, since i opened it, but i approve it