Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual sorting of perspectives #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sipraga
Copy link

@sipraga sipraga commented Sep 26, 2023

Users can select a manual sorting method and then rearrange the list of perspectives using newly added functions pers-sorting-move-left/right.

Users can select a manual sorting method and then rearrange the list of
perspectives using newly added functions pers-sorting-move-left/right.
@gcv
Copy link
Collaborator

gcv commented Sep 29, 2023

Thanks, this looks like a useful feature. Unfortunately, the implementation does not work for me.

First, the change to the perspective struct adds a field called sorted-time, but all the code references persp-sorting-time.

Second, even if I change persp-sorting-time to persp-sorted-time, calls to (persp-names) still fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants