fix(psalm-matrix): set up minimum supported php version #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
2. developing
st3iny
force-pushed
the
fix/psalm-matrix/set-up-min-php-version
branch
from
e3b6a02 to
16afb1e
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/psalm-matrix/set-up-min-php-version
branch
from
16afb1e to
f5fc4be
Compare
skjnldsv
approved these changes
Nov 16, 2024
juliusknorr
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PHP 8.4 will be installed but Psalm is not yet compatible. This will cause the workflow to fail on all apps when run against server master.
Installing the minimum required version should be good enough.
It will still break if newer server versions drop support for old PHP versions and an app spans many server versions (e.g. Groupware apps). This needs to be fixed in the version matrix action directly where the minimum version should be emitted instead of the maximum version.
Failing example: https://github.com/nextcloud/twofactor_webauthn/actions/runs/11871838013/job/33084844902?pr=689 [PHP 8.4]
Working example (with this fix): https://github.com/nextcloud/twofactor_webauthn/actions/runs/11872013494/job/33085209828?pr=690 [PHP 8.1]