Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reuse): compile before checking compliance #478

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

max-nextcloud
Copy link
Contributor

Changes to js dependencies may break compliance.
This only becomes apparent after compiling the js.

Make sure the check runs on the actual js after the compilation so errors are shown for commits that do not include artifacts.

Changes to js dependencies may break compliance.
This only becomes apparent after compiling the js.

Make sure the check runs on the actual js after the compilation
so errors are shown for commits that do not include artifacts.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud merged commit 8ce0251 into master Dec 16, 2024
5 checks passed
@max-nextcloud max-nextcloud deleted the fix/compile-before-reuse-check branch December 16, 2024 14:52
@AndyScherzinger
Copy link
Member

HI @max-nextcloud @juliusknorr

This is a text specific solution not working for other repositories and needs to be reverted!

  • Android / iOS / Python does have any of this in place
  • Apps that don't contain compiled JS will fail because you now enforce licenses via dependencies to be in the repo but the fsfe scanner outside of the repo won't compile the repo, hence that check fails because reuse doesn't allow for shipping licenses which aren't referenced to a file

Hence the above solution is specific to some repos only and should be a separate template.

What is generally useful and to be kept is

        with:
          persist-credentials: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants