Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version in MANIFEST #94

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix version in MANIFEST #94

wants to merge 1 commit into from

Conversation

matthdsm
Copy link
Collaborator

Perhaps also find a way to keep the version numbers in sync across the repo?

@matthdsm matthdsm requested a review from jagedn November 13, 2024 08:23
@jagedn
Copy link
Collaborator

jagedn commented Nov 13, 2024

if I'm not wrong the jsonPlugin gradle task update this manifest when building the zip

@matthdsm
Copy link
Collaborator Author

There has to be an issue with it somewhere I think 🤔
I'm seeing the following in my nextflow logs

Nov-12 09:39:36.154 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins declared=[[email protected]]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins default=[]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins resolved requirement=[[email protected]]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginUpdater - Installing plugin nf-nomad version: 0.3.0
Nov-12 09:39:36.204 [main] INFO  org.pf4j.AbstractPluginManager - Plugin '[email protected]' resolved
Nov-12 09:39:36.204 [main] INFO  org.pf4j.AbstractPluginManager - Start plugin '[email protected]'

@jagedn
Copy link
Collaborator

jagedn commented Nov 13, 2024

Will take a look, meanwhile we can merge your PR

@matthdsm
Copy link
Collaborator Author

I just checked the zip from the latest release and I can confirm the version in the manifest is correct. Perhaps it's something on my end

@abhi18av abhi18av marked this pull request as draft November 13, 2024 13:40
@abhi18av
Copy link
Member

Hi @matthdsm , marking this as draft till you give a go ahead for the update.

The version in particular file hasn't caused issues earlier so maybe there's some nextflow.config of env variable file which is pointing to the wrong version of the plugin 🤔

@matthdsm
Copy link
Collaborator Author

Hi,

I investigated a bit more, and the issue lies in the plugin somewhere.
The version is defined in 2 locations:
$NXF_ASSETS/plugins/nf-nomad-0.3.0/classes/META-INF/MANIFEST.MF
and
$NXF_ASSETS/plugins/nf-nomad-0.3.0/META-INF/MANIFEST.MF

The manifest in the classes dir is set to 0.1.2, whereas the other one is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants