-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advection of arbitrary fields #668
Draft
timspainNERSC
wants to merge
126
commits into
develop
Choose a base branch
from
issue99_337_advection
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tsimdg.git into issue99_337_advection
…tsimdg.git into issue99_337_advection
timspainNERSC
commented
Dec 2, 2024
timspainNERSC
force-pushed
the
issue99_337_advection
branch
from
December 2, 2024 14:12
8b1147b
to
b68d156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advection of arbitrary fields
Fixes #99 & fixes #337
Change Description
ModelArray
for one advection time step. This is a wrapper around theIDynamics::advectField()
function which will advect a 2D or 3DModelArray
, using the slicing infrastructure to reduce the 3D array to a series of 2D fields, advect them using the 2D advection functions provided by the kernel, and reconstruct the 3D field, again usingModelArraySlice
s.DynamicsKernel::advectField()
which will interface with the dynamics code to advect a 2DModelArray
field by one advection time step.AdvectionDynamicsKernel
to the dynamics, which just advects ice fields according to the ocean velocity.Incorporates the slicing changes (#736).
Test Description
Adds two similar tests,
testFieldAdvection
indynamics/test
andtestDynamics
incore/test
. These both set up a 51 x 51 domain, create a circular region of ice in the centre with solid body rotation as the velocity field. A snow depth field that is sinusoidal with angle around the centre is then advected and the field tested every time that the soldi body rotation field makes a quarter turn. The test is an 8 sample approximation to the Fourier transform for the degree 1 Fourier coefficients. That is, it extracts the amplitude of the sinusoidal and cosinusoidal variation around the disk. The two components are then compared to the original sinusoid field with appropriate phase shifts to ensure the field is rotating as a solid body.In the case of the test in
core/test
a similar ice temperature 3D field is also advected and tested in the same manner.