Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow handling #760

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Workflow handling #760

merged 6 commits into from
Dec 13, 2024

Conversation

jwallwork23
Copy link
Contributor

Workflow handling

In the interests of green computing, development efficiency and avoiding unnecessary CI runs, this PR sets up paths for workflow handling, so that the linters are only run if the source code or build code change and the test suite is only run if the test suite, build system, or config files change.

The PR also fixes a copy-paste error in the linting workflow (introduced in #759).

@jwallwork23 jwallwork23 added enhancement New feature or request ICCS Tasks or reviews for the ICCS team testing labels Dec 10, 2024
@jwallwork23 jwallwork23 self-assigned this Dec 10, 2024
@jwallwork23
Copy link
Contributor Author

If you check the Actions logs, you should see that:

  • My initial push (at 9d1059e) didn't trigger any CI jobs because nothing in the source code, build system, or config files changed.
  • My second push (at 61523e8) triggered the linting workflows (but not test workflows) because I added that they should be run if the linting.yml workflow file itself changes.
  • My third push (at 562bd6d) also triggered the test suite workflows because I added that they should be run if the test_suite.yml workflow file itself changes.

@jwallwork23 jwallwork23 marked this pull request as ready for review December 10, 2024 11:09
Copy link
Member

@einola einola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea!

But isn't there a mistake on line 14/19 cf line 29/34 in linting.yml?


jobs:
clang-format:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v2
- name: clang-format
- name: cmake-format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this change belong in line 29/34?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good spot - fixed in 470d3bd.

@jwallwork23 jwallwork23 requested a review from einola December 12, 2024 09:45
@jwallwork23 jwallwork23 merged commit d6e732a into develop Dec 13, 2024
5 checks passed
@jwallwork23 jwallwork23 deleted the workflow-handling branch December 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ICCS Tasks or reviews for the ICCS team testing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants